Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GUNC for additional QC #394

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Add GUNC for additional QC #394

merged 5 commits into from
Feb 23, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Feb 22, 2023

Closes #387

Also updates the diagram to include COCONCT that was missing from the previous PR

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested review from skrakau and d4straub February 22, 2023 14:09
@github-actions
Copy link

github-actions bot commented Feb 22, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 188550c

+| ✅ 156 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-02-23 13:53:27

d4straub
d4straub approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections, but it might be good to add a note in the CHANGELOG?

docs/output.md Outdated Show resolved Hide resolved
@jfy133
Copy link
Member Author

jfy133 commented Feb 23, 2023

Of all things to forget - and agree with the header change!

d4straub
d4straub reviewed Feb 23, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jfy133 @d4straub
Update CHANGELOG.md [skip ci]
023b664 
Co-authored-by: Daniel Straub <[email protected]>
@jfy133 jfy133 merged commit 68d0223 into nf-core:dev Feb 23, 2023
@jfy133 jfy133 deleted the add-gunc branch February 23, 2023 16:06
@jfy133 jfy133 mentioned this pull request Feb 27, 2023
Merged
10 tasks
@skrakau skrakau mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

@skrakau skrakau Awaiting requested review from skrakau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfy133 @d4straub